search

checkly / headless-recorder

Chrome extension that records your browser interactions and generates a Playwright or Puppeteer script.
https://checklyhq.com/headless-recorder
MIT License
15.03k stars 722 forks source link

Some improvements #23

Closed c19 closed 6 years ago

c19 commented 6 years ago
  1. clicks and inputs now basically works. [tested on bing.com searches]
  2. output a json that feed to GenericScript.js
  3. usage: node src/GenericScript.js data.json data.json is the plugin output json.
tnolet commented 6 years ago

@c19 Thanks for the PR! However, your PR completely changes the expected behaviour of the code generated. I can see what you're doing but the idea of Puppeteer Recorder is that it creates a fairly easy to read, imperative puppeteer script. This means I won't merge the PR.

I would like to use some of your ideas on de-doubling events etc. Is it ok if I use some of your code as inspiration? I will mark you as a contributor to this repo.

tnolet commented 6 years ago

@c19 I would recommend you keep adding things to your fork of this repo. Saving to servers is not something in scope right now.

c19 commented 6 years ago

Sure, You can use any of the code you want. I understand.

Tim Nolet notifications@github.com 于2018年9月20日周四 下午11:18写道：

@c19 https://github.com/c19 I would recommend you keep adding things to your fork of this repo. Saving to servers is not something in scope right now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/checkly/puppeteer-recorder/pull/23#issuecomment-423222586, or mute the thread https://github.com/notifications/unsubscribe-auth/ACY61DPPUezIm0GxBsQiNDnsaepMZuW9ks5uc7HEgaJpZM4Wuqxf .