search

checkly / headless-recorder

Chrome extension that records your browser interactions and generates a Playwright or Puppeteer script.
https://checklyhq.com/headless-recorder
MIT License
15.03k stars 722 forks source link

Selector string not quoted when using data attribute #36

Closed prlyons closed 5 years ago

prlyons commented 5 years ago

I am using the custom data attribute. In my case it's data-pweb-logical-id. When the selector is transformed to javascript there are no quotes around the value of the data attribute and the puppeteer script fails without them.

The recorder returns: await page.waitForSelector('[data-pweb-logical-id={{dynamictable|Col1||Col1}|{cells|||Flow}}]')

And I would like it to return: await page.waitForSelector('[data-pweb-logical-id="{{dynamictable|Col1||Col1}|{cells|||Flow}}"]')

tnolet commented 5 years ago

hi @prlyons I'm not completely following. Can you show me a screenshot of what you type into the input box on the settings tab?

prlyons commented 5 years ago

image

tnolet commented 5 years ago

@prlyons Will have a closer look at thuis after the holidays

prlyons commented 5 years ago

OK thanks for talking a look

On Dec 26, 2018, at 10:35 AM, Tim Nolet notifications@github.com wrote:

@prlyons https://github.com/prlyons Will have a closer look at thuis after the holidays

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/checkly/puppeteer-recorder/issues/36#issuecomment-449982616, or mute the thread https://github.com/notifications/unsubscribe-auth/AFKVCG2jKcTeNw-NUHrKWb_q9BGeBgXSks5u85dBgaJpZM4Zagkm.

tnolet commented 5 years ago

@prlyons sorry for the long wait, this is clearly a bug. https://github.com/checkly/puppeteer-recorder/blob/402d47cc3cbf2c09fcdcf15147bde9896626ca80/src/content-scripts/index.js#L114

easy to fix luckily. Will push out a bugfix release today or tomorrow.

prlyons commented 5 years ago

Thanks!

Reid Lyons

On Jan 8, 2019, at 3:27 AM, Tim Nolet notifications@github.com wrote:

@prlyons sorry for the long wait, this is clearly a bug. https://github.com/checkly/puppeteer-recorder/blob/402d47cc3cbf2c09fcdcf15147bde9896626ca80/src/content-scripts/index.js#L114

easy to fix luckily. Will push out a bugfix release today or tomorrow.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.