checkly / headless-recorder

Chrome extension that records your browser interactions and generates a Playwright or Puppeteer script.
https://checklyhq.com/headless-recorder
MIT License
15.03k stars 722 forks source link

fix(iframe-events): Support for iframe click events #48

Closed rationalthinker1 closed 5 years ago

rationalthinker1 commented 5 years ago

Fixes #12, Fixes #47

Pull Request Template

Description

First of all, I have to say, whoever built this is a genius. It is very well divided but yet cohesive and it flows well. However, I was set on creating the iframe functionality myself but it seems like it was already done but the script wasn't applied to all frames, just the top frame. I also removed a reference to elements-to-bind-to as it was suppose to in #39. Btw, this is my first pull request and first time actually contributing to a open source project via coding.

Type of change

How Has This Been Tested?

All existing test passed. I also tested again the two examples in #12, namely https://giving.kcm.org and https://www.goodmanmfg.com/product-registration

Checklist:

tnolet commented 5 years ago

@rationalthinker1 this is awesome, and you're making me blush 😊I will review it tomorrow morning and if all good I will push a new release to the Chrome store.

tnolet commented 5 years ago

LGTM and works as described