First of all, I have to say, whoever built this is a genius. It is very well divided but yet cohesive and it flows well. However, I was set on creating the iframe functionality myself but it seems like it was already done but the script wasn't applied to all frames, just the top frame. I also removed a reference to elements-to-bind-to as it was suppose to in #39. Btw, this is my first pull request and first time actually contributing to a open source project via coding.
Type of change
[X] Bug fix (non-breaking change which fixes an issue)
@rationalthinker1 this is awesome, and you're making me blush 😊I will review it tomorrow morning and if all good I will push a new release to the Chrome store.
Fixes #12, Fixes #47
Pull Request Template
Description
First of all, I have to say, whoever built this is a genius. It is very well divided but yet cohesive and it flows well. However, I was set on creating the iframe functionality myself but it seems like it was already done but the script wasn't applied to all frames, just the top frame. I also removed a reference to
elements-to-bind-to
as it was suppose to in #39. Btw, this is my first pull request and first time actually contributing to a open source project via coding.Type of change
How Has This Been Tested?
All existing test passed. I also tested again the two examples in #12, namely https://giving.kcm.org and https://www.goodmanmfg.com/product-registration
Checklist:
npm run lint
passes with no errors.npm run test
passes with no errors.