checkly / headless-recorder

Chrome extension that records your browser interactions and generates a Playwright or Puppeteer script.
https://checklyhq.com/headless-recorder
MIT License
15.03k stars 722 forks source link

Bug: togglePause on re-opening popup fixed #53

Closed DennisLoska closed 5 years ago

DennisLoska commented 5 years ago

The state did not load correctly after closing the popup and re-opening it again. The state would instead be the default state (isPaused=false) because the state was saved to _isPaused, which is wrong! After removing the lowdash and saving the state back to the actual state isPaused the pause-button is working again correctly.

Pull Request Template

Description

Please include a summary of the change or which issue is fixed. Also, include relevant motivation and context. Remember, as mentioned in the contribution guidelines that PR's should be as atomic as possible 1 feature === 1 PR. 1 bugfix === 1 PR.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

tnolet commented 5 years ago

Hey @DennisLoska thanks for contributing! I will check this after the weekend!

DennisLoska commented 5 years ago

@tnolet I literally just changed one character, but feel free checking :D

tnolet commented 5 years ago

LGMT

tnolet commented 5 years ago

@DennisLoska I just published v0.5.3 to the Chrome Store. This contains your fix. Thanks again.