checkly / headless-recorder

Chrome extension that records your browser interactions and generates a Playwright or Puppeteer script.

https://checklyhq.com/headless-recorder

MIT License

15.03k stars 722 forks source link

refactor(options/components/App): improve dataAttribute setting #81

Closed a631807682 closed 4 years ago

a631807682 commented 4 years ago

Pull Request Template

Description

Remove data-* of dataAttribute description, it's hard to understand, not only data-*, all attribute work.
Trim dataAttribute setting.

Type of change

[x] Refactor (non-breaking change)

How Has This Been Tested?

Spaces do not affect dataAttribute settings

Checklist:

[x] My code follows the style guidelines of this project. npm run lint passes with no errors.
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes. npm run test passes with no errors.

tnolet commented 4 years ago

@a631807682 thanks for contributing. Please see my review.

maxigimenez commented 4 years ago

LGTM 👍 , thanks for contributing @a631807682