checkly / headless-recorder

Chrome extension that records your browser interactions and generates a Playwright or Puppeteer script.
https://checklyhq.com/headless-recorder
MIT License
15.03k stars 722 forks source link

Deku/playwright port #96

Closed kumardeepakr3 closed 4 years ago

kumardeepakr3 commented 4 years ago

Pull Request Template

Description

Please include a summary of the change or which issue is fixed. Also, include relevant motivation and context. Remember, as mentioned in the contribution guidelines that PR's should be as atomic as possible 1 feature === 1 PR. 1 bugfix === 1 PR.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

tnolet commented 4 years ago

@kumardeepakr3 this looks very interesting. Any reason for immediately closing the PR? We would love to make Playwright available as a part of Puppeteer Recorder.

kumardeepakr3 commented 4 years ago

Hey @tnolet , I was just trying something for a internal hackathon project. I saw that puppeteer's extension was created by you but there is nothing that existed for playwright. I saw on Playwright's github repo too. There was an open issue pending there. So I tweaked the codegen to output code for puppeteer recorder for playwright.

I closed the PR immediately because I was intending to merge changes to my master branch rather than for the main project.

Also I see that you have plans of extending the scope of the recorder to playwright. I'll be happy to help and collaborate if needed.

tnolet commented 4 years ago

@kumardeepakr3 gotcha! Thanks for explaining