checkly / jamstack-deploy

Measure cloud providers and check which fits better for your Jamstack App.
https://jamstackdeploy.com
MIT License
31 stars 9 forks source link

sorted providers by performance #17

Closed kumar-kalyan closed 2 years ago

kumar-kalyan commented 2 years ago

Pull Request Template

Description

Sorted the cloud provider names by performances issue:https://github.com/checkly/jamstack-deploy/issues/10 PR's should be as atomic as possible 1 feature === 1 PR. 1 bugfix === 1 PR.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/checkly/jamstack-deploy/EL34uYFy8QUS1jR2nq4BJNNEyaBu
✅ Preview: https://jamstack-deploy-git-fork-kum9748ar-master-checkly.vercel.app

ianaya89 commented 2 years ago

Hi @kum9748ar, thanks for your contribution. I am not seeing here the providers are being sorted by performance, this is just alphabetical order. The sort by performance needs an API interaction to get all providers metrics and use the TTFB to sort them in the client

kumar-kalyan commented 2 years ago

@ianaya89 Thanks for your valuable feedback I will work on it :)