checkly / public-roadmap

Checkly public roadmap. All planned features, updates and tweaks.
https://checklyhq.com
37 stars 7 forks source link

For a retried request, expose the first attempt failure logs #217

Closed aliasgerkw closed 1 year ago

aliasgerkw commented 2 years ago

💡 For general support requests and bug reports, please go to checklyhq.com/support

Is your feature request related to a problem? Please describe. This check failed in retry request, is it possible to find out what was the failure in first attempt - https://app.checklyhq.com/checks/f9826520-be69-4c24-b941-4fdc3447606e/results/api/adb39a45-0308-4274-bd6f-aecc4aa502d9

Describe the solution you'd like I feel consumer should be aware of what has made the first attempt failed in case there is any

Describe alternatives you've considered None

Additional context NA

tnolet commented 2 years ago

@aliasgerkw this would be a good upgrade, I'm tentatively adding this to our larger initiative on tweaking some alerting and results logic.

https://github.com/checkly/public-roadmap/issues/208

drakirnosslin commented 1 year ago

@aliasgerkw - Hey, I just wanted to let you know that we've started working on this, & have the first iteration of the design ready & would appreciate it if you could look at it & let us know what you think.


The flow is available here: https://t.maze.co/154564376


Cheers!

aliasgerkw commented 1 year ago

Thanks @drakirnosslin looks good.

drakirnosslin commented 1 year ago

@aliasgerkw - Retry Insights is now in beta if you want to try it out - Head over to the labs section & enable 'Retry Insights' & for any future retry runs you'll get run results for both the initial & subsequent runs.

Cheers!

aliasgerkw commented 1 year ago
Screenshot 2023-05-02 at 12 18 59 PM Screenshot 2023-05-02 at 12 20 03 PM

@drakirnosslin Hey Rikard, I enabled beta but can only see Attempt 2 in all failures. Not getting Attempt 1 tab as mentioned in screen shot of change logs. Or does it applicable only for future runs after enabling retries?

drakirnosslin commented 1 year ago

Hey @aliasgerkw - Results for both attempts will only be available for check runs done after you enable the beta flag as we didn't store result data for the initial run before so there's nothing to fetch. If you trigger a run that has the 'double check on failure' & is set to fail after you enabled the beta flag you should get a run with two results back.

Let me know if that doesn't work!

aliasgerkw commented 1 year ago

Hey @drakirnosslin this looks good.

Screenshot 2023-05-05 at 12 55 52 PM

Just one suggestion, can we not retry on same location as attempt 1?

Screenshot 2023-05-05 at 1 52 26 PM

Thanks team for considering this request.

drakirnosslin commented 1 year ago

@aliasgerkw Hey Aliasger, happy you think so!

Thanks for the feedback; we're retrying from a different location to avoid false positives due to network outages between the location & the test target or other issues with the location itself.

Could you explain a bit more why you'd like to retry from the same location?

Cheers, and have a great weekend!

aliasgerkw commented 1 year ago

Got it, avoid false alarm is also fine. I am good with it. Thanks for clarification.

tnolet commented 1 year ago

@drakirnosslin please move this to done