checkly / public-roadmap

Checkly public roadmap. All planned features, updates and tweaks.
https://checklyhq.com
37 stars 7 forks source link

GeneralAssertionBuilder's notContains method calls AssertionComparison.CONTAINS inside #306

Closed MikulasMascautanu closed 1 year ago

MikulasMascautanu commented 1 year ago

Is your feature request related to a problem? Please describe. The notContains method of GeneralAssertionBuilder calls CONTAINS AssertionComparison inside. Here is a permalink to the line of code.

This results, for example, in this unexpected behavior:

Describe the solution you'd like The notContains method should call NOT_CONTAINS AssertionComparison inside it, as follows:

    notContains(target) {
        return this._toAssertion(AssertionComparison.NOT_CONTAINS, target);
    }
clample commented 1 year ago

@MikulasMascautanu thank you again for tracking down this bug and fixing it! Your PR is now released in checkly@4.0.5. Just a heads up, we recently moved the NPM package from @checkly/cli to checkly.