checkly / terraform-provider-checkly

Terraform provider for the Checkly monitoring service
https://registry.terraform.io/namespaces/checkly
44 stars 5 forks source link

SSL checks are not added #48

Closed vassbence closed 3 years ago

vassbence commented 3 years ago

Describe the bug SSL cert checks are not uploaded correctly (at least they are not visible from the UI)

image

Version v0.8.0

To Reproduce Use this example check

resource "checkly_alert_channel" "email" {
  email {
    address = var.checkly_alert_email
  }
}

resource "checkly_check" "root_domain_check" {
  name                   = "root_domain_check"
  type                   = "API"
  activated              = true
  should_fail            = false
  frequency              = 30
  double_check           = true
  ssl_check              = true
  degraded_response_time = 300
  max_response_time      = 500

  locations = [
    "eu-central-1",
    "us-east-1"
  ]

  alert_settings {
    escalation_type = "RUN_BASED"

    run_based_escalation {
      failed_run_threshold = 2
    }

    ssl_certificates {
      enabled         = true
      alert_threshold = 30
    }

    reminders {
      amount   = 5
      interval = 30
    }
  }

  alert_channel_subscription {
    channel_id = checkly_alert_channel.email.id
    activated  = true
  }

  request {
    url              = "https://${local.website_domain}/"
    follow_redirects = false
    assertion {
      source     = "STATUS_CODE"
      comparison = "EQUALS"
      target     = "200"
    }
  }
}

Expected behavior Should be able to set SSL cert checks via terraform

Additional context Thanks for the awesome work, this is just a very minor thing I saw but I thought it was worth mentioning :)

umutuzgur commented 3 years ago

Hey @vassbence! Thanks for creating the issue. This apparently has slipped our attention. I will add it to our backlog to address it soon. We are really glad you enjoy using the terraform provider 🎉

umutuzgur commented 3 years ago

Hey @vassbence! You can now set the ssl settings in the new version. Thanks for lettings us know about it