checkmarx-ltd / Cx-Client-Common

3 stars 12 forks source link

Retry variable incorrectly scoped causes exceptions during long Teamcity scans #155

Open AntGarSil opened 3 years ago

AntGarSil commented 3 years ago

Description

Retries on authentication failures do not reset on succesful authentication.

Expected Behavior

The Teamcity plugin utilises Cx-Client-Common with a failure tolerance of 3 authentication errors.  This should reset after succesful authentication.

Actual Behavior

Failed authentication retries do not reset after succesfull authentication.  Tokens expire after an hour and are reset succesfully, however after 3 hours the retries become 0, and the plugin throws an exception.

Reproduction

Configure a scan using the Checkmarx Teamcity plugin that takes over 3 hours.  A null pointer exception will be triggered.

Environment Details