checkmarx-ltd / Cx-Client-Common

3 stars 12 forks source link

Fix for master slave mode any failures in scan, build suceeds #170

Closed SubhadraSahoo closed 3 years ago

SubhadraSahoo commented 3 years ago

…s was failing. And it is serialized so as to work in master slave ode if during scan any exception occurs , the exception was not getting added to results object. Hence failTheBuild() in CxScanBuilder class not not making the build fail/unstable . This issue was discovered during defect AB#2334. The issue was even if user gives wrong user name and password, the job still continue to be SUCCESS in master slave mode

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change.

References

Include supporting link to GitHub Issue/PR number

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist