checkout / checkout-sdk-java

Checkout.com SDK for Java
MIT License
25 stars 29 forks source link

Apache core 5 support (Spring Boot 3) #369

Open antoineriou opened 1 year ago

antoineriou commented 1 year ago

Environment

Description

We are migrating our app from spring boot 2.X to spring boot 3.X. A major change is the use of org.apache.hc.core5.http instead of org.apache.http.

In our app we are using the CheckoutSdk.builder() to instantiate a CheckoutApi Bean and we provide it a custom HttpClientBuilder which uses some custom Interceptors.

We are not able to find a way of using the new apache HttpClientBuilder with Checkout SDK. Is it possible to allow/implement the use of the new HttpClientBuilder from org.apache.hc.core5.http ?

Proposed Solution

N/A

armando-rodriguez-cko commented 1 year ago

Hello @antoineriou! We'll take a look and give you an answer soon. Thank you

armando-rodriguez-cko commented 8 months ago

Hi @antoineriou next month we will try to implement it.

antoineriou commented 8 months ago

Hello @armando-rodriguez-cko, good news ! Thank you so much 🤝

jzrebiec commented 2 months ago

hello @armando-rodriguez-cko can you provide any update on this?

armando-rodriguez-cko commented 2 months ago

Hi @jzrebiec and @antoineriou. We reprioritised the updates and implementations, so we didn’t have time to continue this change. However, it is still open, and we will try to resume work on it in the coming months, although we don’t have an ETA yet. Apologies for not updating this information here sooner. In any case, you have the opportunity to submit a PR to update the SDK with this proposal. Please feel free to do so, and I will be glad to review it.