search

checkout / frames-android

Frames Android: making native card payments simple
https://www.checkout.com/docs/integrate/sdks/android-sdk
MIT License
47 stars 33 forks source link

Don't load 3ds page redirection #139

Closed benju69 closed 1 year ago

benju69 commented 1 year ago

Describe the bug When I add a card with 3DS 2, after the authentication, I'm redirected to my callback page like lalalab.com/success or lalalab.com/failure

To Reproduce Steps to reproduce the behavior:

  1. Go to the card form
  2. Add a test card
  3. Authenticate the card with 3ds in webview
  4. See the webview redirection

Expected behavior Don't display this page In your WebViewClient, don't wait the page to load you can override shouldOverrideUrlLoading and just check the url

Screenshots Screenshot_20221027_192841 Screenshot_20221027_192909

patrick-hoban-cko commented 1 year ago

Hey @benju69 thanks for raising this.

This is an improvement we're planning to release either in the next major release, or in a follow-up minor release after (depending on timelines).

Thanks for your patience!

benju69 commented 1 year ago

UP: Issue is still here in version 4.0.0?

maxim-nosov-cko commented 1 year ago

Hi @benju69

From v4.0.0+, URL loading will be overridden for known URLs (success_url, failure_url) new web view client can be found here.