checkout / frames-android

Frames Android: making native card payments simple
https://www.checkout.com/docs/integrate/sdks/android-sdk
MIT License
47 stars 32 forks source link

Feature/autofill #188

Closed benju69 closed 1 year ago

benju69 commented 1 year ago

Issue

Resolves #47

Proposed changes

Add Autofill for credit card number, date and cvv fields in compose

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

About the Autofill api https://bryanherbst.com/2021/04/13/compose-autofill/ https://developer.android.com/reference/kotlin/androidx/compose/ui/autofill/AutofillNode

benju69 commented 1 year ago

Can you check this? @maxim-nosov-cko

patrick-hoban-cko commented 1 year ago

Hey @benju69, awesome that you're raising PRs to our repo, we love to see it 💯

Unfortunately we can't add this sort of functionality to the SDK due to compliance reasons. We have taken steps to ensure our SDKs allow merchants to adhere to low levels of PCI compliance, which means they should not directly touch or alter card details - hence we can't add an autofill feature at this time without a more thorough review.

If you have any questions around compliance and the implications of this sort of functionality, please feel to message me directly, or drop me an email.

benju69 commented 1 year ago

Hey @benju69, awesome that you're raising PRs to our repo, we love to see it 💯

Unfortunately we can't add this sort of functionality to the SDK due to compliance reasons. We have taken steps to ensure our SDKs allow merchants to adhere to low levels of PCI compliance, which means they should not directly touch or alter card details - hence we can't add an autofill feature at this time without a more thorough review.

If you have any questions around compliance and the implications of this sort of functionality, please feel to message me directly, or drop me an email.

Hey @patrick-hoban-cko yes tell me more about compliance please. I don't understand this is a Android feature for users to add more easily the card info, nothing related with merchants, we had this feature before in the version before 4.0

patrick-hoban-cko commented 1 year ago

Hey @benju69 feel free to drop me an email at patrick.hoban@checkout.com and I'd be happy to discuss more.

benju69 commented 1 year ago

I dropped you an email @patrick-hoban-cko