checkout / frames-android

Frames Android: making native card payments simple
https://www.checkout.com/docs/integrate/sdks/android-sdk
MIT License
51 stars 35 forks source link

[Frame] disable sending billingAddress if form is disabled or not edited #195

Closed jheng-hao-lin-cko closed 1 year ago

jheng-hao-lin-cko commented 1 year ago

Issue

PIMOB-1767

Proposed changes

Problem Currently the BillingAddress is including the payment tokenisation process no matter whether the form is enabled or whether the BillingAddress is edited by the user. Which causes the SDK sending a default empty BillingAddress with the default country instead of a null value.

Solution

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc...

fabio-insolia-cko commented 1 year ago

LGTM but let's wait for @chintan-soni-cko before merging it

jheng-hao-lin-cko commented 1 year ago

LGTM. Can you check? why verification-full is unable to send the slack message? here

The secret was not setup to expose to PR and now have updated it. it works fine now.