Closed chintan-soni-cko closed 11 months ago
Nice work! We would need some changes as space doens't seem to allow inputting the cardholder name.
Also any language other than English won't be able to type, is this intentional?
@jheng-hao-lin-cko Thank you for calling out improvement here. Please find my inline comments:
Issue
PIMOB-2086.
Proposed changes
Provide a feature to hide it from the payment form. The cardholder's name can be set as a hidden field on the payment form. A merchant would set it as a hidden field if they want it to show on the billing address instead. Provide a feature to hide it from the payment form.
Add validation in the payment form if the cardholder is mandatory. If it is not valid then show the error
Added cardholder name support in Theming functionality of SDK
Changes for the sample app The default UI has the cardholder name on the payment form by default, and it’s set as optional The theme UI has the cardholder name on the payment form by default, and it’s set as mandatory The custom UI has the cardholder name updated along with the design
How to test:
card1.webm
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc...