checkout / frames-android

Frames Android: making native card payments simple
https://www.checkout.com/docs/integrate/sdks/android-sdk
MIT License
47 stars 32 forks source link

PIMOB:2086: Implemented Cardholder name management in Payment form #216

Closed chintan-soni-cko closed 11 months ago

chintan-soni-cko commented 11 months ago

Issue

PIMOB-2086.

Proposed changes

card1.webm

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc...

chintan-soni-cko commented 11 months ago

Nice work! We would need some changes as space doens't seem to allow inputting the cardholder name.

Also any language other than English won't be able to type, is this intentional?

@jheng-hao-lin-cko Thank you for calling out improvement here. Please find my inline comments:

  1. Allowing space for cardholder names improved
  2. Allowing other languages to support. however, due to regex for English characters, it won't and it was part of the previous PR. Hence, I will add this improvement in the next PR addressing the changes.