1 Add the cardholder name to the Billing form and the Default UI should not contain it
Merchants can set the field as an optional or mandatory
Add support for it in theming capabilities
If the CardHolder name is added in the billing form and payment form then take this field from the payment form and ignore it from the billing form because token API has only 1 field for the cardholder name
Removed regex validation from cardholder name because API does not contain specific validation, unlike all address fields. See reference
Changes in the sample app: Add the cardholder name in the Billing form from Custom UI and hide it from the payment form.
What to test
Verify mandatory and optional field validation in the billing form
Verify behaviour by adding it in custom and theming sample apps
Verify correct values of the name is passing into the Token API
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[X] Reviewers assigned
[X] I have performed a self-review of my code and manual testing
[X] Lint and unit tests pass locally with my changes
[X] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if applicable)
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc...
Issue
/PIMOB-2085
Proposed changes
1 Add the cardholder name to the Billing form and the Default UI should not contain it
What to test
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc...