checkout / frames-android

Frames Android: making native card payments simple
https://www.checkout.com/docs/integrate/sdks/android-sdk
MIT License
47 stars 32 forks source link

PIMOB-2085: Add cardholderField into a Billing form and hit the token api #217

Closed chintan-soni-cko closed 10 months ago

chintan-soni-cko commented 10 months ago

Issue

/PIMOB-2085

Proposed changes

1 Add the cardholder name to the Billing form and the Default UI should not contain it

  1. Merchants can set the field as an optional or mandatory
  2. Add support for it in theming capabilities
  3. If the CardHolder name is added in the billing form and payment form then take this field from the payment form and ignore it from the billing form because token API has only 1 field for the cardholder name
  4. Removed regex validation from cardholder name because API does not contain specific validation, unlike all address fields. See reference
  5. Changes in the sample app: Add the cardholder name in the Billing form from Custom UI and hide it from the payment form.

What to test

screenshots

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc...