checkout / frames-android

Frames Android: making native card payments simple
https://www.checkout.com/docs/integrate/sdks/android-sdk
MIT License
47 stars 32 forks source link

PIMOB: 2133 -mapping of country in phone object from token response improved #223

Closed chintan-soni-cko closed 10 months ago

chintan-soni-cko commented 10 months ago

Issue

PIMOB-2113

Proposed changes

1 Receiving on token response, the country object from the phone should be correct as sent in the token request. 2 updated unit tests

Test Steps

Steps to reproduce the issue: 1 fill payment form along with billing address details. Choose a country as the united kingdom 2 Hit the pay button and verify the token response. It contains an invalid country object from the phone in the Token response from the SDK. See attached video for reference.

Expected: Receiving on token response, country object from the phone should be correct as sent in the token request. [Uploading billling_recording_20230821_094805.webm…]()

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc...