checkout / frames-android

Frames Android: making native card payments simple
https://www.checkout.com/docs/integrate/sdks/android-sdk
MIT License
47 stars 32 forks source link

PIMOB:2182- kotlin sample app updated #241

Closed chintan-soni-cko closed 8 months ago

chintan-soni-cko commented 8 months ago

Issue

PIMOB-2182

Proposed changes

  1. Added default style for CVV component config
  2. Added Custom and default CVV components for 2 different schemes visa and Maestro along with button for tokenisation

Changes in the SDK:

  1. Improvement in CVVInputField, while recomposition from cvvcomponent config when user typing. viewmodel was creating everytime
  2. improvement in InternalCVVComponentMediator, when user typing and the isEnteredCVV value changes then asynchronous recomposition result in an issue for the component

Overall improvement: from the merchant app if it doing multiple time recomposing due to another components. SDK component will work as expected

Test Steps

If there's any functionality change, please list a step by step guide of how to verify the changes, and/or upload a screen recording for any visible changes.

  1. Verify calling multiple times CVVComponent() using same mediator should only load one cvv component and button should enable and disable
  2. Verify adding AMEX scheme should enable 4 digit long cvv length to type
  3. Change inputfieldstyle and see the output. Example attached in recording

Checklist

Screen_recording_20231005_184057.webm

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc...