search

checkout / frames-android

Frames Android: making native card payments simple
https://www.checkout.com/docs/integrate/sdks/android-sdk
MIT License
47 stars 32 forks source link

feature/PIMOB-2262_Artifact_generation_and_download_via_GHA #257

Closed fabio-insolia-cko closed 7 months ago

fabio-insolia-cko commented 7 months ago

Issue

PIMOB-2262

Proposed changes

Simplification of the general flows; loads of jobs (unit test, assemble and lint) were always enabled for all the flows, so I have removed the redundant flag. While doing the assemble task, I have introduced a new boolean flag to:

Screenshot 2023-11-27 at 17 19 07

Test Steps

  1. Do a change on checkout module
  2. verify that all the job will trigger
  3. Verify that only app and example-app flow will have artifacts to download

Checklist

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

fabio-insolia-cko commented 7 months ago

@fabio-insolia-cko Quick question: I have downloaded the artifacts. It only contains the apks from the example_app_frames and not from the app module. Do I miss something here?

https://github.com/checkout/frames-android/actions/runs/7008300534 https://github.com/checkout/frames-android/actions/runs/7008300564 both flows are from the same pull but one build the example app and the other build the other app Happy to provide further explanation offline