checkout / frames-android

Frames Android: making native card payments simple
https://www.checkout.com/docs/integrate/sdks/android-sdk
MIT License
47 stars 32 forks source link

Fix: Await risk sdk actions #275

Closed precious-ossai-cko closed 2 weeks ago

precious-ossai-cko commented 1 month ago

Issue

https://checkout.atlassian.net/browse/PRISM-11245

Proposed changes

Await acitons on the Risk SDK before continuing.

Test Steps

No changes in interaction or operation or test order.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

NB: Regardless of success or failure within Risk, the completion handler is called on both scenarios.

NB: All asynchronous actions have a maximum timeout of 5 seconds.

jheng-hao-lin-cko commented 2 weeks ago

Thanks for the changes. Have we done any manual tests? If so let's rebase and merge this branch

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
77.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud