feature/PIMOB-2639_Fix_for_phone_numeber_on_RTL_languages - Githubissues

checkout / frames-android

Frames Android: making native card payments simple

https://www.checkout.com/docs/integrate/sdks/android-sdk

MIT License

47 stars 32 forks source link

feature/PIMOB-2639_Fix_for_phone_numeber_on_RTL_languages #278

Closed fabio-insolia-cko closed 3 days ago

fabio-insolia-cko commented 3 days ago

Issue

PIMOB-2639

Proposed changes

Added BidiFormatter to handle RTL languages for phone number

Test Steps

BEFORE THE FIX

https://github.com/checkout/frames-android/assets/123394131/a69bb19b-c8c4-40b0-b672-b4c7c57e7168

Open the sample app with the prefillData (as per requirement)
Open the device settings and set the device Language to any RTL language (in the video above is Arabic)
Reopen the app and verify that the phone is displayed correctly

AFTER THE FIX

https://github.com/checkout/frames-android/assets/123394131/2c54a7b2-146e-4556-ac07-db3cf5ce1443

Checklist

[x] Reviewers assigned
[x] I have performed a self-review of my code and manual testing
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if applicable)

sonarcloud[bot] commented 3 days ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
61.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud