search

checkout / frames-react-native

Frames React Native
17 stars 25 forks source link

Hide Card Icon with `hideIcon` Optional Prop #9

Closed waleedshkt closed 2 years ago

waleedshkt commented 2 years ago

To cater to some users demand of hiding card icons, I believe this optional prop will be very useful. Also, with the issue around incorrect detection of Discover card which is linked to the third-party dependency creditcard-types, the proposed hideIcon prop will offer temporary clean fix by giving developer the option to not display icon.

waleedshkt commented 2 years ago

It's up to the maintainers to patch the code however they like. But I strongly believe that hideIcon prop logic is much simpler than if were to go for showIcon. Also, I think scheme icons should be shown as default. So hideIcon set to false (default) makes much more sense