search

checkpoint-restore / checkpointctl

A tool for in-depth analysis of container checkpoints
Apache License 2.0
87 stars 15 forks source link

test: add e2e test for json format #116

Closed rst0git closed 5 months ago

rst0git commented 5 months ago

This pull request adds a test case that verifies the output JSON format for checkpointctl.

rst0git commented 5 months ago

cc: @Parthiba-Hazra

codecov-commenter commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2f15c0b) 62.96% compared to head (436b6ef) 78.72%.

Files Patch % Lines
json.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #116 +/- ## =========================================== + Coverage 62.96% 78.72% +15.76% =========================================== Files 7 7 Lines 1161 1161 =========================================== + Hits 731 914 +183 + Misses 388 185 -203 - Partials 42 62 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 months ago

Test Results

49 tests  +1   49 :white_check_mark: +1   1s :stopwatch: ±0s  1 suites ±0    0 :zzz: ±0   1 files   ±0    0 :x: ±0 

Results for commit 436b6ef4. ± Comparison against base commit 2f15c0bc.

:recycle: This comment has been updated with latest results.

adrianreber commented 5 months ago

I see a coverage of 20% of json.go. Would a higher coverage require a more complex test process?

rst0git commented 5 months ago

Would a higher coverage require a more complex test process?

Not necessarily. I will update the patch to extend the test coverage.

rst0git commented 5 months ago

@adrianreber I've updated the pull request to increase test coverage.