search

checkpoint-restore / checkpointctl

A tool for in-depth analysis of container checkpoints
Apache License 2.0
87 stars 15 forks source link

Add annotations for creating OCI images from checkpoint archives #127

Closed Parthiba-Hazra closed 3 weeks ago

Parthiba-Hazra commented 2 months ago

These annotations provide metadata including the container manager, container-name, pod, namespace for creating OCI images from checkpoint archives.

github-actions[bot] commented 2 months ago

Test Results

55 tests  ±0   55 :white_check_mark: ±0   1s :stopwatch: ±0s  1 suites ±0    0 :zzz: ±0   1 files   ±0    0 :x: ±0 

Results for commit 1c47bb24. ± Comparison against base commit 873b71c9.

:recycle: This comment has been updated with latest results.

Parthiba-Hazra commented 2 months ago

@rst0git @adrianreber Let's first confirm the structure of the annotation. After that, I will add additional annotations for Podman and CRI-O.

adrianreber commented 2 months ago

This feels redundant: checkpointctl.checkpoint. Let's remove one of those words. I think checkpointctl is not really necessary. Even if we said so earlier.

rst0git commented 2 months ago

@adrianreber How should we handle backward comparability with CRI-O and Podman? Do we want to deprecate the old annotations and provide support for them up to specified version, or to simply replace the annotations with a "breaking change".

adrianreber commented 2 months ago

@adrianreber How should we handle backward comparability with CRI-O and Podman? Do we want to deprecate the old annotations and provide support for them up to specified version, or to simply replace the annotations with a "breaking change".

For CRI-O it is relatively easy as we only use one annotation. We will just handle both (for some time or forever). For Podman I would personally do the same. No need to break anything for the annotations used by Podman. For the ones not used I would just rename them.

rst0git commented 1 month ago

@adrianreber PTAL

codecov-commenter commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.73%. Comparing base (6c3a263) to head (27b455e). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #127 +/- ## ======================================= Coverage 78.73% 78.73% ======================================= Files 11 11 Lines 1260 1260 ======================================= Hits 992 992 Misses 201 201 Partials 67 67 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adrianreber commented 4 weeks ago

The test failure is unexpected. Seems like some project changed the minimum Go version without changing its version. Strange.

I guess we need another PR doing make vendor before we can merge this one.

Parthiba-Hazra commented 4 weeks ago

The test failure is unexpected. Seems like some project changed the minimum Go version without changing its version. Strange.

I guess we need another PR doing make vendor before we can merge this one.

@adrianreber I opened one here #133

adrianreber commented 4 weeks ago

Please rebase.