Closed snprajwal closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
f2a5886
) 78.20% compared to head (75b10f0
) 78.20%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
19 tests ±0 19 :heavy_check_mark: ±0 0s :stopwatch: ±0s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0
Results for commit 75b10f0f. ± Comparison against base commit f2a58864.
How did you change those version dependencies?
Don't we have dependabot to do these changes.
Should we really change indirect dependencies?
Do we have something like make vendor
to verify that the dependencies are correct during CI?
I updated the dependencies by running go get -u
, and then vendored it with go mod tidy
+ go mod vendor
. I don't think Dependabot tracks indirect dependencies.
Do we have something like
make vendor
to verify that the dependencies are correct during CI?
Doesn't look like it, let me add it. Would you want it in this PR itself, or a different PR?
I updated the dependencies by running
go get -u
, and then vendored it withgo mod tidy
+go mod vendor
. I don't think Dependabot tracks indirect dependencies.
Should we really change indirect dependencies? I am not yet convinced. We have those because other projects pull them in and I am not sure it is correct to update those if the vendored in projects use something else.
Do we have something like
make vendor
to verify that the dependencies are correct during CI?Doesn't look like it, let me add it. Would you want it in this PR itself, or a different PR?
Separate PR sounds good.
Something like go mod tidy vendor verify and then maybe a git diff to verify nothing changed.
Please have a look at other go projects how they verify stable dependencies in CI.
We have those because other projects pull them in and I am not sure it is correct to update those if the vendored in projects use something else.
AFAIK, doing go get -u
updates the indirect dependencies to the version that the direct dependencies themselves use. So they are changed only if one of our direct deps has bumped them up in the respective go.mod
.
Should we configure dependbot with dependency-type: "all"
?
allow:
# Allow both direct and indirect updates for all packages
- dependency-type: "all"
I am still skeptical about updating indirect dependencies. That sounds unnecessary.
We have those because other projects pull them in and I am not sure it is correct to update those if the vendored in projects use something else.
AFAIK, doing
go get -u
updates the indirect dependencies to the version that the direct dependencies themselves use. So they are changed only if one of our direct deps has bumped them up in the respectivego.mod
.
From the documentation it looks like go get -u
attempts to upgrade all direct and indirect (transitive) dependencies^1, and indirect dependencies can be updated beyond what is required by the direct dependencies.
@rst0git so, are in favour of upgrading indirect dependencies or not? :wink:
so, are in favour of upgrading indirect dependencies or not?
I also think it may be unnecessary to upgrade the indirect dependencies unless we have a specific reason to do so.
Alright, in that case we can close this
Just bumps up a bunch of deps to the newer versions.