checkpoint-restore / checkpointctl

A tool for in-depth analysis of container checkpoints
Apache License 2.0
95 stars 15 forks source link

ci: add job to check increase in binary size #59

Closed snprajwal closed 1 year ago

snprajwal commented 1 year ago

This job checks the difference in binary size across commits in a PR, and fails if the difference is more than a set maximum limit. This allows us to detect early on if there is any possible bloating in the binary due to poorly structured dependencies. The job can be overridden by adding a bloat-ok label to the PR.

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (d2600ca) 80.31% compared to head (400987c) 80.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #59 +/- ## ======================================= Coverage 80.31% 80.31% ======================================= Files 3 3 Lines 386 386 ======================================= Hits 310 310 Misses 55 55 Partials 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

Test Results

23 tests  ±0   23 :heavy_check_mark: ±0   0s :stopwatch: ±0s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 400987c2. ± Comparison against base commit d2600ca6.

:recycle: This comment has been updated with latest results.

snprajwal commented 1 year ago

fatal: invalid upstream 'main^'

Slightly weird. This works locally, even with the single quotes. I'll debug it on a separate branch.

snprajwal commented 1 year ago

Right, now the workflow can't find the test/check-size.sh file.

adrianreber commented 1 year ago

Looks good. Can you make CI happy using the bloat-ok label?

snprajwal commented 1 year ago

I don't seem to have the rights to add labels to the PR

adrianreber commented 1 year ago

I added the label. It still runs the job. I thought it should ignore it now.

snprajwal commented 1 year ago

I thought the same too 🤔 weird behaviour

snprajwal commented 1 year ago

Nice, the workflow doesn't run since the PR is labeled. Can either of you please remove the label so we can see if it gets triggered. Also, I've added a line to test if the script is found by the CI shell. If that works, I'll remove and force push so that we can merge this

snprajwal commented 1 year ago

Great! The script is present, getting rid of the test and pushing.

snprajwal commented 1 year ago

:thinking: why did it not run now

snprajwal commented 1 year ago

Ah, got it. I overrode the default triggers for PR events.

snprajwal commented 1 year ago

Now we're good to go! :tada:

snprajwal commented 1 year ago

@rst0git can you add the label to make CI happy please?