checkpoint-restore / checkpointctl

A tool for in-depth analysis of container checkpoints
Apache License 2.0
87 stars 15 forks source link

refactor: move table rendering into own funcs #60

Closed snprajwal closed 1 year ago

snprajwal commented 1 year ago

The logic for rendering tables with the checkpoint data was all present in a single function showContainerCheckpoint(). This has now been refactored to provide each table its own function that can be called to render it. This increases code maintainability going forward as more and more tables are added to the checkpointctl show command.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 90.14% and project coverage change: +0.25 :tada:

Comparison is base (da69a6b) 80.31% compared to head (2d433eb) 80.56%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #60 +/- ## ========================================== + Coverage 80.31% 80.56% +0.25% ========================================== Files 3 3 Lines 386 391 +5 ========================================== + Hits 310 315 +5 Misses 55 55 Partials 21 21 ``` | [Impacted Files](https://app.codecov.io/gh/checkpoint-restore/checkpointctl/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [container.go](https://app.codecov.io/gh/checkpoint-restore/checkpointctl/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y29udGFpbmVyLmdv) | `82.78% <89.23%> (+0.36%)` | :arrow_up: | | [checkpointctl.go](https://app.codecov.io/gh/checkpoint-restore/checkpointctl/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hlY2twb2ludGN0bC5nbw==) | `84.21% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

Test Results

23 tests  ±0   23 :heavy_check_mark: ±0   0s :stopwatch: ±0s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 2d433eb4. ± Comparison against base commit da69a6b0.

:recycle: This comment has been updated with latest results.