checkpoint-restore / checkpointctl

A tool for in-depth analysis of container checkpoints
Apache License 2.0
87 stars 15 forks source link

ci: use Ubuntu for tests instead of Fedora #64

Closed snprajwal closed 1 year ago

snprajwal commented 1 year ago

Previously, the Fedora container image was being used to test checkpointctl since the Ubuntu image had an outdated version of bats. This does not affect the tests themselves, as the coverage workflow continues to use ubuntu-latest without issues. This change will eliminate the need for having a privileged container to run criu while generating image files for tests.

github-actions[bot] commented 1 year ago

Test Results

23 tests  ±0   23 :heavy_check_mark: ±0   0s :stopwatch: ±0s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit f210f529. ± Comparison against base commit fa6a6f2a.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 90.14% and project coverage change: +0.25 :tada:

Comparison is base (da69a6b) 80.31% compared to head (f210f52) 80.56%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #64 +/- ## ========================================== + Coverage 80.31% 80.56% +0.25% ========================================== Files 3 3 Lines 386 391 +5 ========================================== + Hits 310 315 +5 Misses 55 55 Partials 21 21 ``` | [Impacted Files](https://app.codecov.io/gh/checkpoint-restore/checkpointctl/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [container.go](https://app.codecov.io/gh/checkpoint-restore/checkpointctl/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y29udGFpbmVyLmdv) | `82.78% <89.23%> (+0.36%)` | :arrow_up: | | [checkpointctl.go](https://app.codecov.io/gh/checkpoint-restore/checkpointctl/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hlY2twb2ludGN0bC5nbw==) | `84.21% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

adrianreber commented 1 year ago

I prefer distribution packages instead of installing from a third source.

snprajwal commented 1 year ago

I agree, but the bats package on Ubuntu has been updated for 22.10 and 23.04. Unfortunately, the GitHub image uses 22.04. I think using the NPM package is a less expensive workaround to running a container with a different distribution.

adrianreber commented 1 year ago

In addition to bats being too old in Ubuntu, the same is true for shellcheck and CRIU doesn't work at all. So we need additional repositories for every package and Fedora just has the correct version of all of it.

snprajwal commented 1 year ago

Ah understood. This is unnecessary then, let's close it.