Closed snprajwal closed 1 year ago
23 tests ±0 23 :heavy_check_mark: ±0 0s :stopwatch: ±0s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0
Results for commit f210f529. ± Comparison against base commit fa6a6f2a.
:recycle: This comment has been updated with latest results.
Patch coverage: 90.14
% and project coverage change: +0.25
:tada:
Comparison is base (
da69a6b
) 80.31% compared to head (f210f52
) 80.56%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I prefer distribution packages instead of installing from a third source.
I agree, but the bats
package on Ubuntu has been updated for 22.10 and 23.04. Unfortunately, the GitHub image uses 22.04. I think using the NPM package is a less expensive workaround to running a container with a different distribution.
In addition to bats being too old in Ubuntu, the same is true for shellcheck and CRIU doesn't work at all. So we need additional repositories for every package and Fedora just has the correct version of all of it.
Ah understood. This is unnecessary then, let's close it.
Previously, the Fedora container image was being used to test checkpointctl since the Ubuntu image had an outdated version of bats. This does not affect the tests themselves, as the coverage workflow continues to use
ubuntu-latest
without issues. This change will eliminate the need for having a privileged container to run criu while generating image files for tests.