search

checkpoint-restore / checkpointctl

A tool for in-depth analysis of container checkpoints
Apache License 2.0
87 stars 15 forks source link

Add integration test with podman #68

Open snprajwal opened 1 year ago

snprajwal commented 1 year ago

Currently, we only run tests with BATS. This does not let us test changes in real world scenarios with containers. An integration test where a container is checkpointed and then the archive used for testing is much more robust and bulletproof.

rst0git commented 1 year ago

It might be good to have integration tests with both CRI-O and Podman.

snprajwal commented 1 year ago

One clarification for this - since the podman test I'm writing uses looper and the existing test uses piggie, would it make sense to have two separate BATS file for each of these tests? If the output differs, we can change it accordingly in the relevant file. Currently, the same test file works for both checkpoints, but I don't think that will stay the same as we add more features/ tests in the future.

snprajwal commented 1 year ago

One clarification for this - since the podman test I'm writing uses looper and the existing test uses piggie, would it make sense to have two separate BATS file for each of these tests? If the output differs, we can change it accordingly in the relevant file. Currently, the same test file works for both checkpoints, but I don't think that will stay the same as we add more features/ tests in the future.

@rst0git @adrianreber what do you think of this?