fix: remove redundant nodes in process tree

checkpoint-restore / checkpointctl

A tool for in-depth analysis of container checkpoints

Apache License 2.0

87 stars 15 forks source link

fix: remove redundant nodes in process tree #71

Closed snprajwal closed 1 year ago

snprajwal commented 1 year ago

The recursive logic used to process nodes in the process tree was accidentally appending child nodes twice. This has been fixed by removing the addition of the extra node at the same depth before processing the child.

Fixes #70

github-actions[bot] commented 1 year ago

Test Results

24 tests ±0 24 :heavy_check_mark: ±0 0s :stopwatch: ±0s   1 suites ±0   0 :zzz: ±0   1 files ±0   0 :x: ±0

Results for commit ee4989a4. ± Comparison against base commit d91aab96.

:recycle: This comment has been updated with latest results.

snprajwal commented 1 year ago

Nice, one more bug in the binary size checker. We should be comparing against the last non-merge commit, not the entire history of merge commits. I'll open a PR for this.