search

checkpoint-restore / checkpointctl

A tool for in-depth analysis of container checkpoints
Apache License 2.0
87 stars 15 forks source link

feat: display sockets in process tree #94

Closed snprajwal closed 10 months ago

snprajwal commented 11 months ago

This is now supported with the --sockets flag.

github-actions[bot] commented 11 months ago

Test Results

48 tests  +2   48 :heavy_check_mark: +2   1s :stopwatch: ±0s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 4ff6bb7d. ± Comparison against base commit a699e2d3.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage: 49.27% and project coverage change: -3.18% :warning:

Comparison is base (9c2098c) 82.30% compared to head (bafb3cc) 79.12%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #94 +/- ## ========================================== - Coverage 82.30% 79.12% -3.18% ========================================== Files 6 6 Lines 842 915 +73 ========================================== + Hits 693 724 +31 - Misses 111 150 +39 - Partials 38 41 +3 ``` | [Files Changed](https://app.codecov.io/gh/checkpoint-restore/checkpointctl/pull/94?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore) | Coverage Δ | | |---|---|---| | [tree.go](https://app.codecov.io/gh/checkpoint-restore/checkpointctl/pull/94?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore#diff-dHJlZS5nbw==) | `69.94% <25.53%> (-18.03%)` | :arrow_down: | | [checkpointctl.go](https://app.codecov.io/gh/checkpoint-restore/checkpointctl/pull/94?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore#diff-Y2hlY2twb2ludGN0bC5nbw==) | `93.90% <100.00%> (+0.42%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/checkpoint-restore/checkpointctl/pull/94/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

snprajwal commented 10 months ago

Is Codecov broken? It seems to not update the coverage, or report the status via CI anymore

rst0git commented 10 months ago

Is Codecov broken? It seems to not update the coverage, or report the status via CI anymore

It seems to work:

snprajwal commented 10 months ago

Ah, the Codecov comment has been edited now for the latest force push. It wasn't doing that for the previous force pushes though (edit history says this is the first edit in two weeks). Weird. Anyway, glad to know it works

adrianreber commented 10 months ago

I have also seen cases where the codecov comment was not updated in other PRs. Seems to happen sometimes.