search

checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.85k stars 576 forks source link

Codacy: condition is always true/false #2120

Open mihalicyn opened 1 year ago

mihalicyn commented 1 year ago

https://app.codacy.com/gh/mihalicyn/criu/issues?&filters=W3siaWQiOiJMYW5ndWFnZSIsInZhbHVlcyI6W119LHsiaWQiOiJDYXRlZ29yeSIsInZhbHVlcyI6W119LHsiaWQiOiJMZXZlbCIsInZhbHVlcyI6W119LHsiaWQiOiJQYXR0ZXJuIiwidmFsdWVzIjpbIjIyMzciXX0seyJpZCI6IkF1dGhvciIsInZhbHVlcyI6W119XQ==

TaeminHa commented 1 year ago

Hi! I'm a student from UT Austin, and would be happy to take on this issue! Can you assign this to me?

mihalicyn commented 1 year ago

Feel free to take :)

Jayanth19524 commented 1 year ago

is this issue solved??

mihalicyn commented 1 year ago

@TaeminHa ?

TaeminHa commented 1 year ago

Hi, this issue is resolved. I'll create a separate PR to put the changes in separate commits as discussed.

Snorch commented 1 year ago

No this issue is NOT resolved, we have really-really draft PR #2141, which from the first glance tries to do the right thing in code. But it is not ready to review as it has bad commit structure: no signed-offs, no rebase to latest criu-dev, empty commits, bad commit subject and description format/wording, fixup commits.

Read https://github.com/checkpoint-restore/criu/blob/criu-dev/CONTRIBUTING.md it contains all the information about how the right PR should look like.

vishisht-dubey commented 1 year ago

Hii @Snorch i would like to contibute to this issue can u assign this to me?

Snorch commented 9 months ago

No real need to assign, comment that you are working on this is enough, @vishisht-dubey @Min2who please communicate with each other not to do the same thing twice =)

rohitsinghnaruka commented 1 week ago

Hii , @Snorch & @mihalicyn i'm Working on this .