Codacy: condition is always true/false

[mihalicyn]

https://app.codacy.com/gh/mihalicyn/criu/issues?&filters=W3siaWQiOiJMYW5ndWFnZSIsInZhbHVlcyI6W119LHsiaWQiOiJDYXRlZ29yeSIsInZhbHVlcyI6W119LHsiaWQiOiJMZXZlbCIsInZhbHVlcyI6W119LHsiaWQiOiJQYXR0ZXJuIiwidmFsdWVzIjpbIjIyMzciXX0seyJpZCI6IkF1dGhvciIsInZhbHVlcyI6W119XQ==

[TaeminHa]

Hi! I'm a student from UT Austin, and would be happy to take on this issue! Can you assign this to me?

[mihalicyn]

Feel free to take :)

[Jayanth19524]

is this issue solved??

[mihalicyn]

@TaeminHa ?

[TaeminHa]

Hi, this issue is resolved. I'll create a separate PR to put the changes in separate commits as discussed.

[Snorch]

No this issue is NOT resolved, we have really-really draft PR #2141, which from the first glance tries to do the right thing in code. But it is not ready to review as it has bad commit structure: no signed-offs, no rebase to latest criu-dev, empty commits, bad commit subject and description format/wording, fixup commits.

Read https://github.com/checkpoint-restore/criu/blob/criu-dev/CONTRIBUTING.md it contains all the information about how the right PR should look like.

[vishisht-dubey]

Hii @Snorch i would like to contibute to this issue can u assign this to me?

[Snorch]

No real need to assign, comment that you are working on this is enough, @vishisht-dubey @Min2who please communicate with each other not to do the same thing twice =)

[rohitsinghnaruka]

Hii , @Snorch & @mihalicyn i'm Working on this .

[AtriChatterjee1]

HI ! @Snorch and @mihalicyn ! I am a new contributor to criu, and would love to work on this

[AtriChatterjee1]

Hey @Snorch Can't find the issue on codacy for some reason, mind sharing it again