checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.93k stars 585 forks source link

Make some no-op permission changes not requiring privilege. #2207

Closed osctobe closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 50.90% and project coverage change: +0.02 :tada:

Comparison is base (2d6f04c) 70.35% compared to head (5600cd1) 70.38%.

:exclamation: Current head 5600cd1 differs from pull request most recent head 9a99d21. Consider uploading reports for the commit 9a99d21 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## criu-dev #2207 +/- ## ============================================ + Coverage 70.35% 70.38% +0.02% ============================================ Files 133 134 +1 Lines 34001 34024 +23 ============================================ + Hits 23923 23948 +25 + Misses 10078 10076 -2 ``` | [Impacted Files](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [criu/include/util.h](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y3JpdS9pbmNsdWRlL3V0aWwuaA==) | `100.00% <ø> (ø)` | | | [criu/sk-unix.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y3JpdS9zay11bml4LmM=) | `74.52% <ø> (ø)` | | | [criu/tty.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y3JpdS90dHkuYw==) | `77.44% <ø> (ø)` | | | [criu/util.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y3JpdS91dGlsLmM=) | `63.38% <39.02%> (-1.01%)` | :arrow_down: | | [criu/files-reg.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y3JpdS9maWxlcy1yZWcuYw==) | `75.36% <77.77%> (+0.29%)` | :arrow_up: | | [criu/cgroup.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y3JpdS9jZ3JvdXAuYw==) | `74.94% <100.00%> (+0.37%)` | :arrow_up: | | [criu/memfd.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y3JpdS9tZW1mZC5j) | `81.81% <100.00%> (ø)` | | ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2207/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

avagin commented 1 year ago

I have merged this series with one minor fix of the lint warning. We need to figure out how to test these new calls.