pipes: Plug pipe fd leak in "Unable to set a pipe size" error case.

osctobe commented 1 year ago

A trivial fix for error path leaking pipe fds.

mihalicyn commented 1 year ago

LGTM

but please fix https://github.com/checkpoint-restore/criu/pull/2208/checks?check_run_id=14450206848

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.06 :warning:

Comparison is base (f018893) 70.61% compared to head (18c405c) 70.55%.

:exclamation: Current head 18c405c differs from pull request most recent head 6bcadb7. Consider uploading reports for the commit 6bcadb7 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## criu-dev #2208 +/- ## ============================================ - Coverage 70.61% 70.55% -0.06% ============================================ Files 133 133 Lines 33243 33502 +259 ============================================ + Hits 23473 23636 +163 - Misses 9770 9866 +96 ``` | [Impacted Files](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [criu/pipes.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y3JpdS9waXBlcy5j) | `82.44% <0.00%> (ø)` | | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2208/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

checkpoint-restore / criu

pipes: Plug pipe fd leak in "Unable to set a pipe size" error case. #2208

Codecov Report