Closed rst0git closed 1 year ago
Patch coverage: 68.42
% and project coverage change: -0.32
:warning:
Comparison is base (
e6427c5
) 70.72% compared to head (06ca563
) 70.41%.:exclamation: Current head 06ca563 differs from pull request most recent head 6d6db09. Consider uploading reports for the commit 6d6db09 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This is a huge change, but it looks correct. Not entirely sure if this might break packaging CRIU in some places. Hard to tell.
This is a huge change, but it looks correct.
Indeed, these changes clean-up Python 2 compatibility fixes we have introduced over the past few years.
Not entirely sure if this might break packaging CRIU in some places. Hard to tell.
I don't expect these changes to break packaging as we have already added all necessary build dependencies for Python 3 in the 3.18 release.
This pull request removes support for Python 2 in CRIU and disables the CI tests for CentOS 7, as we discussed in https://github.com/checkpoint-restore/criu/issues/2203.