checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.86k stars 576 forks source link

kerndat: Don't fail on NETLINK/nsid support missing. #2213

Closed osctobe closed 1 year ago

osctobe commented 1 year ago

If not dumping netns nor connections, nsid support is not used. Don't fail the run as if the support is needed, the dumping process will fail later.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.16 :warning:

Comparison is base (f5cd44f) 70.68% compared to head (a4d4320) 70.53%.

:exclamation: Current head a4d4320 differs from pull request most recent head f162280. Consider uploading reports for the commit f162280 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## criu-dev #2213 +/- ## ============================================ - Coverage 70.68% 70.53% -0.16% ============================================ Files 133 133 Lines 33248 33508 +260 ============================================ + Hits 23501 23634 +133 - Misses 9747 9874 +127 ``` | [Impacted Files](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [criu/util.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y3JpdS91dGlsLmM=) | `64.44% <0.00%> (ø)` | | | [criu/kerndat.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y3JpdS9rZXJuZGF0LmM=) | `57.73% <33.33%> (ø)` | | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2213/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.