checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.86k stars 576 forks source link

action-scripts: allow shell scripts in rpc mode #2217

Closed rst0git closed 1 year ago

rst0git commented 1 year ago

Container runtimes commonly use CRIU with RPC. However, this prevents the use of action-scripts set in a configuration file due to the explicit scripts mode introduced with commit ac78f13bdfaee260dd4234f054bf4c5d2a373783. This pull request enables container checkpoint/restore with action-scripts specified via configuration file.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.08 :warning:

Comparison is base (1e90fc8) 70.48% compared to head (e74e1a1) 70.41%.

:exclamation: Current head e74e1a1 differs from pull request most recent head 44691ae. Consider uploading reports for the commit 44691ae to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## criu-dev #2217 +/- ## ============================================ - Coverage 70.48% 70.41% -0.08% ============================================ Files 133 134 +1 Lines 33508 33318 -190 ============================================ - Hits 23619 23461 -158 + Misses 9889 9857 -32 ``` | [Impacted Files](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [criu/action-scripts.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y3JpdS9hY3Rpb24tc2NyaXB0cy5j) | `81.08% <87.50%> (ø)` | | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2217/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.