checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.86k stars 576 forks source link

Snprajwal self contained workflow #2220

Closed Snorch closed 1 year ago

Snorch commented 1 year ago

just to test https://github.com/checkpoint-restore/criu/pull/2219

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.08 :tada:

Comparison is base (6cfe7aa) 70.46% compared to head (dff8e0f) 70.55%.

:exclamation: Current head dff8e0f differs from pull request most recent head 0e4cc76. Consider uploading reports for the commit 0e4cc76 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## criu-dev #2220 +/- ## ============================================ + Coverage 70.46% 70.55% +0.08% ============================================ Files 133 134 +1 Lines 33596 33349 -247 ============================================ - Hits 23674 23529 -145 + Misses 9922 9820 -102 ``` [see 13 files with indirect coverage changes](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2220/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Snorch commented 1 year ago
criu/cr-restore.c:3570:15: error: variable ‘restore_task_exec_start’ set but not used [-Werror=unused-but-set-variable]
 3570 |         void *restore_task_exec_start;
      |               ^~~~~~~~~~~~~~~~~~~~~~~
criu/cr-restore.c:3964: error: control reaches end of non-void function [-Werror=return-type]
criu/cr-restore.c: At top level:
cc1: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option ‘-Wno-dangling-pointer’ may have been intended to silence earlier diagnostics
cc1: all warnings being treated as errors
make[3]: *** [/home/runner/work/criu/criu/scripts/nmk/scripts/build.mk:119: criu/cr-restore.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [criu/Makefile:76: criu/built-in.o] Error 2
make[1]: *** [Makefile:268: criu] Error 2
make[1]: Leaving directory '/home/runner/work/criu/criu'
Build failed for commit 69186baf3fc2f3b69fe059ab8a8f3a0710ae4001
Author: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
make: *** [Makefile:106: check-commit] Error 1
Date:   Wed Jul 5 16:30:50 2023 +0800

    break

Verification for https://github.com/checkpoint-restore/criu/pull/2219#pullrequestreview-1521180422, it works smoothly.