Closed rst0git closed 1 year ago
Patch coverage: 66.66%
and project coverage change: -0.05%
:warning:
Comparison is base (
72494ed
) 70.65% compared to head (37b9396
) 70.60%.:exclamation: Current head 37b9396 differs from pull request most recent head 2e84b58. Consider uploading reports for the commit 2e84b58 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Pls add a full description what this ioctl is about and why it is safe to do what you are doing in this patch.
@rst0git ping
Pls add a full description what this ioctl is about and why it is safe to do what you are doing in this patch.
Thank you for the question. I investigated this further and while skipping TIOCSLCKTRMIOS
for unprivileged restore seems to work, it might not be safe. Instead, it seems that allowing CAP_CHECKPOINT_RESTORE
to be used with TIOCSLCKTRMIOS
is more appropriate.
TIOCSLCKTRMIOS
requires CAP_SYS_ADMIN. This causescriu restore
to fail when used with--unprivileged
.