Closed Snorch closed 11 months ago
It looks like that:
Please remove draft/test: introduce some codding style errors to test new approach when merging this PR, this commit is needed just to illustrate the concept.
Patch coverage: 84.61%
and project coverage change: +0.06%
:tada:
Comparison is base (
5fedcaa
) 70.62% compared to head (6ce24a5
) 70.68%. Report is 14 commits behind head on criu-dev.:exclamation: Current head 6ce24a5 differs from pull request most recent head 99d878b. Consider uploading reports for the commit 99d878b to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I've added changes to CONTRIBUTING.md with bad clang-formating examples to PR and a link from warnings to CONTRIBUTING.md, so that it would be easier to understand how this warning should be handled.
I've removed test commit to trigger warnings (it works), so it's now ready to merge.
There are multiple cases where good human readable code block is converted to an unreadable mess by clang-format, so we don't want to rely on clang-format completely. Also there is no way, as far as I can see, to make clang-format only fix what we want it to fix without breaking something.
So let's just display hints inline where clang-format is unhappy. When reviewer sees such a warning it's a good sign that something is broken in codding style around this warning.