Closed Snorch closed 9 months ago
@checkpoint-restore/maintainers I'm not sure about it, but as there seems to be no way to say "<120 is also ok" to clang-format, let's just disable it.
Patch coverage has no change and project coverage change: +0.01%
:tada:
Comparison is base (
a652c68
) 70.68% compared to head (0333869
) 70.69%.:exclamation: Current head 0333869 differs from pull request most recent head 96e723c. Consider uploading reports for the commit 96e723c to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
A friendly reminder that this PR had no activity for 30 days.
The "ColumnLimit: 120" is not only allowing lines to be longer than 80 characters but it also forces line wrapping at 120 characters. If total expression length is more than 120 characters, clang-format will try to wrap it as close to 120 as it can, it would not even allow to wrap at 80 characters if we really want it. But as we all know 80 characters is Linux kernel coding style default and as far as our coding style is based on it it is really strange to prohibit wrapping lines at 80 characters...