search

checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.79k stars 565 forks source link

ci: stop testing ubuntu overlayfs #2268

Closed avagin closed 10 months ago

avagin commented 10 months ago

They break it with each kernel rebase. More details are here: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1857257

Last time, it was fixed a few month ago and it has been broken again in 5.15.0-1046-azure.

codecov-commenter commented 10 months ago

Codecov Report

Patch coverage has no change and project coverage change: -0.04% :warning:

Comparison is base (150eecc) 70.51% compared to head (67d2138) 70.48%.

:exclamation: Current head 67d2138 differs from pull request most recent head 1607f0f. Consider uploading reports for the commit 1607f0f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## criu-dev #2268 +/- ## ============================================ - Coverage 70.51% 70.48% -0.04% ============================================ Files 132 132 Lines 33507 33506 -1 ============================================ - Hits 23628 23616 -12 - Misses 9879 9890 +11 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2268/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adrianreber commented 10 months ago

So the fix is basically to bind mount the criu directory from the outside in the test container and being independent of the file system used by the container. Took me a while to spot that change. Would have been good to mention the change in the commit message.

Besides that both changed tests are happy. LGTM.