Closed yota9 closed 10 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
1e4f5fb
) 70.54% compared to head (1c5357b
) 70.54%.:exclamation: Current head 1c5357b differs from pull request most recent head df497f2. Consider uploading reports for the commit df497f2 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
lgtm
AFAIU Currently most of the times we don't have problems with VVAR segment due to during parking vdso on it's old place mremap is used and during it munmap is called to destination address which results in calling UFFDIO_UNREGISTER. But as for VDSO we don't want to enable uffd for these addresses at firse place.
I find the changelog a bit hard to parse, how about
Currently most of the times we don't have problems with VVAR segment and lazy restore because when VDSO is parked there is an munmap call that calls UFFDIO_UNREGISTER on the destination address. But we don't want to enable userfaultfd for VDSO and VVAR at the first place.
Other than that, LGTM
@rppt Thanks, done. Please merge it since I don't have rights.
Currently most of the times we don't have problems with VVAR segment and lazy restore because when VDSO is parked there is an munmap call that calls UFFDIO_UNREGISTER on the destination address. But we don't want to enable userfaultfd for VDSO and VVAR at the first place.