Closed avagin closed 8 months ago
@avagin Would it be possible to include the patch from https://github.com/checkpoint-restore/criu/pull/2282 in this release?
@rst0git I will add it when it is merged to criu-dev.
Daming Rosefinch
Thank you for your invitation. This name comes from a novel I like. Rosefinch is a mythical animal and Daming Rosefinch is a sword shaped like rosefinch, its Chinese name is "大明朱雀". What is your oponion?
Daming Rosefinch
The word "daming" at first glance looks very similar to damning, which has a different meaning. What do you think about "Vermilion Rosefinch"?
What do you think about "Vermilion Rosefinch"?
A pretty good suggestion. If similarity to damning is not acceptable, Vermilion Rosefinch is the best choice.
This name comes from a novel I like. Rosefinch is a mythical animal and Daming Rosefinch is a sword shaped like rosefinch, its Chinese name is "大明朱雀". What is your oponion?
@znley The format is "material"/"bird breed". Here is the list of all previous releases https://criu.org/Download/criu
@avagin It was only after your reminder that I realized the first word was "material". "Bronze Peacock" should comply with this rule.
1) (minor nit) maybe we can merge https://github.com/checkpoint-restore/criu/commit/6d0e785182 to https://github.com/checkpoint-restore/criu/commit/af31e8e242 as the former is just a fixup. (note: comment style there is also wrong, so we might also want to fix it while at it) 2) we lack Signed-off-by in https://github.com/checkpoint-restore/criu/commit/347c6a8bf @avagin @yota9
Except that, looks good.
we lack Signed-off-by in 347c6a8bf @avagin @yota9
@yota9 can I add your sign-off to this commit?
Sure, thank you very much and sorry for that
Attention: 149 lines
in your changes are missing coverage. Please review.
Comparison is base (
4c1a2ac
) 70.63% compared to head (61a3f23
) 70.51%.:exclamation: Current head 61a3f23 differs from pull request most recent head cd11de3. Consider uploading reports for the commit cd11de3 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@znley I suggest you to choose a name for this release.