checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.77k stars 561 forks source link

Prepare v3.19 #2284

Closed avagin closed 8 months ago

avagin commented 9 months ago

@znley I suggest you to choose a name for this release.

rst0git commented 9 months ago

@avagin Would it be possible to include the patch from https://github.com/checkpoint-restore/criu/pull/2282 in this release?

avagin commented 9 months ago

@rst0git I will add it when it is merged to criu-dev.

znley commented 9 months ago

Daming Rosefinch

Thank you for your invitation. This name comes from a novel I like. Rosefinch is a mythical animal and Daming Rosefinch is a sword shaped like rosefinch, its Chinese name is "大明朱雀". What is your oponion?

rst0git commented 9 months ago

Daming Rosefinch

The word "daming" at first glance looks very similar to damning, which has a different meaning. What do you think about "Vermilion Rosefinch"?

znley commented 9 months ago

What do you think about "Vermilion Rosefinch"?

A pretty good suggestion. If similarity to damning is not acceptable, Vermilion Rosefinch is the best choice.

avagin commented 8 months ago

This name comes from a novel I like. Rosefinch is a mythical animal and Daming Rosefinch is a sword shaped like rosefinch, its Chinese name is "大明朱雀". What is your oponion?

@znley The format is "material"/"bird breed". Here is the list of all previous releases https://criu.org/Download/criu

znley commented 8 months ago

@avagin It was only after your reminder that I realized the first word was "material". "Bronze Peacock" should comply with this rule.

Snorch commented 8 months ago

1) (minor nit) maybe we can merge https://github.com/checkpoint-restore/criu/commit/6d0e785182 to https://github.com/checkpoint-restore/criu/commit/af31e8e242 as the former is just a fixup. (note: comment style there is also wrong, so we might also want to fix it while at it) 2) we lack Signed-off-by in https://github.com/checkpoint-restore/criu/commit/347c6a8bf @avagin @yota9

Except that, looks good.

avagin commented 8 months ago

we lack Signed-off-by in 347c6a8bf @avagin @yota9

@yota9 can I add your sign-off to this commit?

yota9 commented 8 months ago

Sure, thank you very much and sorry for that

codecov-commenter commented 8 months ago

Codecov Report

Attention: 149 lines in your changes are missing coverage. Please review.

Comparison is base (4c1a2ac) 70.63% compared to head (61a3f23) 70.51%.

:exclamation: Current head 61a3f23 differs from pull request most recent head cd11de3. Consider uploading reports for the commit cd11de3 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2284 +/- ## ========================================== - Coverage 70.63% 70.51% -0.13% ========================================== Files 132 132 Lines 33434 33508 +74 ========================================== + Hits 23615 23627 +12 - Misses 9819 9881 +62 ``` | [Files](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore) | Coverage Δ | | |---|---|---| | [criu/apparmor.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore#diff-Y3JpdS9hcHBhcm1vci5j) | `54.15% <100.00%> (+0.14%)` | :arrow_up: | | [criu/include/image.h](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore#diff-Y3JpdS9pbmNsdWRlL2ltYWdlLmg=) | `100.00% <ø> (ø)` | | | [criu/include/parasite.h](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore#diff-Y3JpdS9pbmNsdWRlL3BhcmFzaXRlLmg=) | `100.00% <ø> (ø)` | | | [criu/include/restorer.h](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore#diff-Y3JpdS9pbmNsdWRlL3Jlc3RvcmVyLmg=) | `100.00% <ø> (ø)` | | | [criu/include/rst\_info.h](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore#diff-Y3JpdS9pbmNsdWRlL3JzdF9pbmZvLmg=) | `100.00% <ø> (ø)` | | | [criu/include/util.h](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore#diff-Y3JpdS9pbmNsdWRlL3V0aWwuaA==) | `70.37% <ø> (-29.63%)` | :arrow_down: | | [criu/include/vma.h](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore#diff-Y3JpdS9pbmNsdWRlL3ZtYS5o) | `100.00% <100.00%> (ø)` | | | [criu/libnetlink.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore#diff-Y3JpdS9saWJuZXRsaW5rLmM=) | `75.26% <ø> (-0.27%)` | :arrow_down: | | [criu/mem.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore#diff-Y3JpdS9tZW0uYw==) | `86.30% <ø> (+0.95%)` | :arrow_up: | | [criu/namespaces.c](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore#diff-Y3JpdS9uYW1lc3BhY2VzLmM=) | `69.48% <ø> (ø)` | | | ... and [31 more](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore) | | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/checkpoint-restore/criu/pull/2284/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=checkpoint-restore)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.