Refactor criu plugin baseline v2

checkpoint-restore / criu

Checkpoint/Restore tool

criu.org

Other

2.77k stars 561 forks source link

Refactor criu plugin baseline v2 #2298

Closed rerrabolu closed 5 months ago

rerrabolu commented 8 months ago

rerrabolu commented 7 months ago

My changelist fails for two scenarios:

Cirrus CI / Vagrant Fedora Rawhide based test
Cirrus CI / Vagrant Fedora based test (no VDSO)

Is it possible for me to re-run them as the "details" does not show me if my change is the cause. Furthermore, I see other changelists that are having failures in the same validating element.

avagin commented 7 months ago

@rerrabolu can someone from your team review this change?

dayatsin-amd commented 7 months ago

@rerrabolu can someone from your team review this change?

Sorry, been busy with other things. I will take a look.

github-actions[bot] commented 6 months ago

A friendly reminder that this PR had no activity for 30 days.

avagin commented 5 months ago

@dayatsin-amd friendly ping

rst0git commented 5 months ago

@rerrabolu Would it be possible to add tests that can be used to verify the functionality on a system with GPU?

rerrabolu commented 4 months ago

Thanks for taking time to merge my patch.
I see some lint errors, will try to provide a patch to address it next couple of weeks
I will find out if we could add a small test case to validate CRIU on a system with AMD GPUs. This will take sometime and will require some coordination

rst0git commented 4 months ago

@rerrabolu Some of the lint errors have been fixed in https://github.com/checkpoint-restore/criu/pull/2345.

I have been using the example applications from the following repository for testing locally with MI100 GPU: https://github.com/ROCm/HIP-Examples/tree/master/HIP-Examples-Applications

We could add a few simple test cases, similar to these examples, to the ZDTM test suite.