search

checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.77k stars 561 forks source link

ci: fix docker test #2302

Closed rst0git closed 7 months ago

rst0git commented 7 months ago

The version of docker-ce on Ubuntu 20.04 has been recently updated to 25.0.0-beta.1. However, with this version docker start --checkpoint fails with the following error:

$ docker start --checkpoint=c1 cr
Error response from daemon: failed to create task for container: content digest fdb1054b00a8c07f08574ce52198c5501d1f552b6a5fb46105c688c70a9acb45: not found: unknown

As a workaround, we install the most recent stable version of docker-ce. In addition, to improve code readability, the recursive function call used for retrying container restoration has been replaced with a loop.

0x7f454c46 commented 7 months ago

I remember there was quite a protest from vz guys for bashisms as they don't have bash in the testing setup (?). But this file already has bashisms: ((current_iteration+=1)), so it shouldn't be any worse than before.

Just for curiosity: is it also fixed by pre-initializing current_iteration=0?

avagin commented 7 months ago

@0x7f454c46 I remember I was to tired with all these shellshit and replaced /bin/sh with /bin/bash everywhere, so bash is required to run tests.

Snorch commented 7 months ago

I remember there was quite a protest from vz guys for bashisms as they don't have bash in the testing setup (?).

Thanks for the note, I was not aware of it =)

But I know for sure that we don't run scripts/ci/docker-test.sh in vz ci, so adding bashisms here should be ok anyway.