search

checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.77k stars 561 forks source link

ci: do not use 'tail' for skip-file-rwx-check test #2307

Closed adrianreber closed 6 months ago

adrianreber commented 7 months ago

Newer versions of 'tail' rely on inotify and after a restore 'tail' is unhappy with the state of inotify and just stops.

This replaces 'tail' with a minimal test in C which just keeps a file open to still be able to test how CRIU reacts if the file mode has changed.

The skip-file-rwx-check test sometimes fails if kill is slower than tail ending itself.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b17a73b) 70.62% compared to head (a80cec5) 70.61%.

:exclamation: Current head a80cec5 differs from pull request most recent head f5cd01a. Consider uploading reports for the commit f5cd01a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## criu-dev #2307 +/- ## ============================================ - Coverage 70.62% 70.61% -0.01% ============================================ Files 134 134 Lines 33316 33316 ============================================ - Hits 23528 23526 -2 - Misses 9788 9790 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adrianreber commented 6 months ago

Failing alpine test is tracked here: https://github.com/checkpoint-restore/criu/issues/2313