checkpoint-restore / criu

Checkpoint/Restore tool
criu.org
Other
2.77k stars 561 forks source link

check: verify ino and dev of overlayfs files in /proc/pid/maps #2320

Closed avagin closed 3 months ago

avagin commented 6 months ago

Check that the file device and inode shown in /proc/pid/maps match values returned by stat(2).

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 62.50000% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 70.20%. Comparing base (cb39c62) to head (4bf16da).

:exclamation: Current head 4bf16da differs from pull request most recent head 8e83b7a. Consider uploading reports for the commit 8e83b7a to get more accurate results

Files Patch % Lines
criu/cr-check.c 62.50% 42 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## criu-dev #2320 +/- ## ============================================ - Coverage 70.21% 70.20% -0.01% ============================================ Files 132 132 Lines 34372 34484 +112 ============================================ + Hits 24134 24210 +76 - Misses 10238 10274 +36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Snorch commented 5 months ago

Looks good.

minor nits:

Do we want to add it to kdat?

github-actions[bot] commented 3 months ago

A friendly reminder that this PR had no activity for 30 days.